Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed casing of parameter and fixed return param of Set-AzApiManagementPolicy command #324

Merged
merged 2 commits into from
Aug 26, 2022
Merged

fix: fixed casing of parameter and fixed return param of Set-AzApiManagementPolicy command #324

merged 2 commits into from
Aug 26, 2022

Conversation

pim-simons
Copy link
Contributor

  • Fixed the casing of PolicyFilePath parameter in the Import-AzApiManagementApiPolicy command.
  • Added the -PassThru param to the Set-AzApiManagementPolicy to fix the Import-AzApiManagementApiPolicy, Import-AzApiManagementOperationPolicy and Import-AzApiManagementProductPolicy commands

Closes #322
Closes #323

@netlify
Copy link

netlify bot commented Aug 26, 2022 •
edited
Loading

✅ Deploy Preview for arcus-scripting canceled.

Name Link
🔨 Latest commit 0808c3f
🔍 Latest deploy log https://app.netlify.com/sites/arcus-scripting/deploys/630891122f680400092c2e19

@pim-simons pim-simons added bug Something isn't working area:api-management All issues related to Azure API Management labels Aug 26, 2022
stijnmoreels
stijnmoreels approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@stijnmoreels stijnmoreels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super fast fix for this, 🏁🏎!
Thx, Pim! 😉

src/Arcus.Scripting.ApiManagement/Scripts/Import-AzApiManagementApiPolicy.ps1 Show resolved Hide resolved
src/Arcus.Scripting.ApiManagement/Scripts/Import-AzApiManagementApiPolicy.ps1 Show resolved Hide resolved
src/Arcus.Scripting.ApiManagement/Scripts/Import-AzApiManagementOperationPolicy.ps1 Show resolved Hide resolved
@fgheysels
Copy link
Member

Great find, and thanks for solving this so quickly.

@pim-simons pim-simons merged commit 36a72e7 into arcus-azure:master Aug 26, 2022
@pim-simons pim-simons deleted the fix/import-azapimanagementapipolicy branch August 26, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgheysels fgheysels fgheysels approved these changes

@stijnmoreels stijnmoreels stijnmoreels approved these changes

Assignees
No one assigned
Labels
area:api-management All issues related to Azure API Management bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@pim-simons @fgheysels @stijnmoreels